Reimplement self-healing using internal statistics #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use the value of the var here, not the pointer, as the pointer changes in each iteration of the loop. Add a test to catch this.
range is already safe to use with a nil list.
An in-memory key-value store has been added so the xdss server can report statistics that can the be then consumed from the controllers. The mechanism to detect failing resources has been reimplemented using this store in conjunction with the new ability of detecting which pod is actually reporting an ACK/NACK.
The implementation consist in the EnvoyConfigRevision tainting itself when the internal stats show that the percentage of pods reporting failures is higher that a given threshold. Right now: * A pod is considered "in failure" when it has reported at least one NACK for a given resource version, for at least one resource type. * The percentage of pods required to trigger the taint of a revision is right now hardcoded to 100%.
When a NACK is received by the discovery service, it immediately retries the the same response. This usually does not help because unless something changes in the resource, the client is likely to reject the resource again and again. This leads to a storm of retries that elevates CPU comsumption in the clients, even triggering HPA if enabled. This commit implements a backoff strategy for retries to avoid this situation.
3scale-robot
added
kind/feature
3scale-robot
added
size/XL
|
/ok-to-test |
3scale-robot
added
the
ok-to-test
slopezz
reviewed
May 27, 2021
slopezz
reviewed
May 27, 2021
|
Despite the 2 small typos on comments, awesome job, true self-healing implementation! /lgtm |
|
LGTM label has been added. Git tree hash: c03e509eae7b2e62ec64f7a1c8e71d4ffd96b1c0
|
|
@slopezz suggestions committed! Need to lgtm again :P |
Nice! /lgtm |
|
LGTM label has been added. Git tree hash: 4ccecf50036272dfb2460307c1711ddcbdc85506
|
|
Outstanding job! /lgtm |
raelga
approved these changes
Jun 1, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
/kind feature
/priority important-soon
/assign