feat/extra-container-lifecycle-hooks

[roivaz]

This PR allows coordination for extra containers within the Pod with the shutdown manager. A new annotation has been added that allows a user to specify other container names where the shutdown manager lifecycle hook should also be configured. This is a feature that only makes sense for sidecars.

An example of usage:

---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: kuard
  namespace: default
  labels:
    app: kuard
spec:
  replicas: 1
  selector:
    matchLabels:
      app: kuard
  template:
    metadata:
      labels:
        app: kuard
        marin3r.3scale.net/status: "enabled"
      annotations:
        marin3r.3scale.net/node-id: kuard
        marin3r.3scale.net/ports: envoy-https:8443
        marin3r.3scale.net/shutdown-manager.enabled: "true"
        marin3r.3scale.net/shutdown-manager.extra-lifecycle-hooks: kuard
    spec:
      containers:
        - name: kuard
          image: gcr.io/kuar-demo/kuard-amd64:blue
          ports:
            - containerPort: 8080
              name: http
              protocol: TCP

/kind feature
/priority importantt-soon
/assign

[3scale-robot]

@roivaz: The label(s) priority/importantt-soon cannot be applied, because the repository doesn't have them

In response to this:

This PR allows coordination for extra containers within the Pod with the shutdown manager. A new annotation has been added that allows a user to specify other container names where the shutdown manager lifecycle hook should also be configured. This is a feature that only makes sense for sidecars.

An example of usage:

---
apiVersion: apps/v1
kind: Deployment
metadata:
 name: kuard
 namespace: default
 labels:
   app: kuard
spec:
 replicas: 1
 selector:
   matchLabels:
     app: kuard
 template:
   metadata:
     labels:
       app: kuard
       marin3r.3scale.net/status: "enabled"
     annotations:
       marin3r.3scale.net/node-id: kuard
       marin3r.3scale.net/ports: envoy-https:8443
       marin3r.3scale.net/shutdown-manager.enabled: "true"
       marin3r.3scale.net/shutdown-manager.extra-lifecycle-hooks: kuard
   spec:
     containers:
       - name: kuard
         image: gcr.io/kuar-demo/kuard-amd64:blue
         ports:
           - containerPort: 8080
             name: http
             protocol: TCP

/kind feature
/priority importantt-soon
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[roivaz]

/ok-to-test

[slopezz]

@roivaz should I wait until test re-execution before approving the PR?

[roivaz]

Nope, the kind cluster setup keeps failing in github actions since two weeks ago and I haven't had the time to look at it yet. The tests run without problems locally so I'll just go ahead and merge it.

[slopezz]

Nope, the kind cluster setup keeps failing in github actions since two weeks ago and I haven't had the time to look at it yet. The tests run without problems locally so I'll just go ahead and merge it.

Fair enough!

/lgtm

[3scale-robot]

LGTM label has been added.

Git tree hash: 5599fee84a55fc38c361c932069a8429814d0ed6

[roivaz]

/approve

[3scale-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roivaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment