-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/autogenerate-proto-imports #122
Conversation
/lgtm |
LGTM label has been added. Git tree hash: cd463602ebf07342dbfa1334dc2db0cd7f280a8c
|
LGTM label has been added. Git tree hash: 04ca43bf538e137b629c1333b4ff369697fa6426
|
LGTM label has been added. Git tree hash: 3bfd53428a237c09ea1424f0c8810d5c938137b4
|
/ok-to-test |
New changes are detected. LGTM label has been removed. |
/remove-label ok-to-test |
@roivaz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Context: There is a list of imports in
pkg/envoy/serializer/v3/serializer.go
that is required so the serialization/deserialization code is able to handle proto messages of the Any type. This is a dynamic list of imports as the files containing protobuffer definitions in go-control-plane can change from version to version. So far this list of imports was manually maintained, which is problematic as the list could end up being out of date.This PR automates the process of generating the list of imports:
pkg/envoy/protos/v3
that can be imported from other packages.go.mod
to determine the go-control-plane release in use..pb.go
files that belong to thev3
api version (though the generator is already able to look for other api versions).pkg/envoy/protos/v3
package.go generate
is used to trigger the execution of the code generator from the Makefile when the binary is built.Currently the list of imports is out of date in marin3r-v0.9.0 so a new patch release will be required after this PR as some proto message definitions are missing, resulting in an error if a user tries to use them.
/kind feature
/kind bug
/priority important-soon
/assign