feat/image-env-override #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointing right now to a forked version of the library that includes a couple of small patches: * Logging of differences in the enforcing-reconcilers * Correctly propagate the parent context down to the enforcing-reconcilers We'll get back to upstream once this patches are merged there.
3scale-robot
added
kind/feature
3scale-robot
added
size/M
|
/ok-to-test |
3scale-robot
added
the
ok-to-test
|
/lgtm Please remember to open the PR in operator-utils upstream and link to that PR before merging it |
|
LGTM label has been added. Git tree hash: 34059523e17dc88cf8d9e0a0fe9076c709f712da
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows overriding through an env variable in the image that the operator uses to deploy the discover service, the init manager and the shutdown manager. This should be used both in the operator Deployment and in the webhook Deployment so both EnvoyDeployments and sidecars are affected.
The project has also been upgraded to:
/kind feature
/priority important-soon
/assign