Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go-control-plane v0.10.1 #134

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jan 24, 2022

This PR upgrades go-control-plane to v0.10.1 (changelog: v0.10.0, v0.10.1). The upgrade requires some changes in the code, most notably the switch from "github.com/golang/protobuf/proto" to "google.golang.org/protobuf/proto".

/kind feature
/priority important-soon
/assign

Closes #99

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jan 24, 2022
@roivaz
Copy link
Member Author

roivaz commented Jan 24, 2022

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 24, 2022
@roivaz roivaz changed the title Upgrade to go control plane v0.10.1 Upgrade to go-control-plane v0.10.1 Jan 24, 2022
…plane as it seems some of them have been moved
@slopezz
Copy link
Member

slopezz commented Jan 25, 2022

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a6a3709e338ad9755c53741779f56d04cae7d13

Copy link
Contributor

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roivaz
Copy link
Member Author

roivaz commented Jan 25, 2022

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@3scale-robot 3scale-robot merged commit e3f93e7 into main Jan 25, 2022
@3scale-robot 3scale-robot deleted the feat/go-control-plane-v0.10.1 branch January 25, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/L Requires few days to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to google.golang.org/protobuf
4 participants