Correctly sort ECRs when there are only two in the list #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SortByPublication had a bug where it was checking only one of the candidates' versions but not the other. If there are only two candidates to be sorted then one's version wasn't being examined so the sort ended up being based on publish date only, ignoring the version. Now we check both candidates' versions so version is always the primary sort key, even when there are only two candidates.
3scale-robot
added
needs-kind
|
/kind bug |
3scale-robot
added
kind/bug
ghost
mentioned this pull request
|
Thanks @acnodal-tc for the PR. |
|
/assign |
|
/ok-to-test |
3scale-robot
added
the
ok-to-test
|
/lgtm |
|
LGTM label has been added. Git tree hash: fb739630a41f2f56c00423d5851610250d1f0149
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SortByPublication had a bug where it was checking only one of the
candidates' versions but not the other. If there are only two
candidates to be sorted then one's version wasn't being examined so
the sort ended up being based on publish date only, ignoring the
version.
Now we check both candidates' versions so version is always the
primary sort key, even when there are only two candidates.