Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/extensionconfig #146

Merged
merged 4 commits into from
Oct 14, 2022
Merged

feat/extensionconfig #146

merged 4 commits into from
Oct 14, 2022

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 14, 2022

This PR adds support for ExtensionConfig discovery (https://www.envoyproxy.io/docs/envoy/latest/configuration/overview/extension).

It also reworks the script that generates certificates for local testing, which was not working properly.

The extension configuration discovery has been added to the e2e test to validate it works properly.

/kind feature
/priority important-longterm
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 14, 2022
@3scale-robot 3scale-robot added size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 14, 2022
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c6a80f89417102e42f3ecbbc373355b533914706

@roivaz
Copy link
Member Author

roivaz commented Oct 14, 2022

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 14, 2022
@roivaz
Copy link
Member Author

roivaz commented Oct 14, 2022

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@3scale-robot 3scale-robot merged commit b34174f into main Oct 14, 2022
@3scale-robot 3scale-robot deleted the feat/extensionconfig branch October 14, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants