Metrics

[roivaz]

Expose some of the internal stats of the discovery service server as prometheus metrics:

❯ curl -s localhost:8080/metrics | grep marin3r
# HELP marin3r_xdss_discovery_ack_total Number of discovery ACK responses
# TYPE marin3r_xdss_discovery_ack_total counter
marin3r_xdss_discovery_ack_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.cluster.v3.Cluster"} 1
marin3r_xdss_discovery_ack_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.core.v3.TypedExtensionConfig"} 1
marin3r_xdss_discovery_ack_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.listener.v3.Listener"} 1
marin3r_xdss_discovery_ack_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.route.v3.RouteConfiguration"} 1
# HELP marin3r_xdss_discovery_info Number of discovery NACK responses
# TYPE marin3r_xdss_discovery_info untyped
marin3r_xdss_discovery_info{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.cluster.v3.Cluster",version="d58c797b7"} 0
marin3r_xdss_discovery_info{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.core.v3.TypedExtensionConfig",version="584d665fdc"} 0
marin3r_xdss_discovery_info{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.listener.v3.Listener",version="5d6b855897"} 0
marin3r_xdss_discovery_info{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.route.v3.RouteConfiguration",version="5c848bc54c"} 0
# HELP marin3r_xdss_discovery_nack_total Number of discovery NACK responses
# TYPE marin3r_xdss_discovery_nack_total counter
marin3r_xdss_discovery_nack_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.listener.v3.Listener"} 3
# HELP marin3r_xdss_discovery_requests_total Number of discovery requests
# TYPE marin3r_xdss_discovery_requests_total counter
marin3r_xdss_discovery_requests_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.cluster.v3.Cluster"} 1
marin3r_xdss_discovery_requests_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.core.v3.TypedExtensionConfig"} 1
marin3r_xdss_discovery_requests_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.listener.v3.Listener"} 1
marin3r_xdss_discovery_requests_total{node_id="envoy1",pod_name="local",resource_type="type.googleapis.com/envoy.config.route.v3.RouteConfiguration"} 1

There seems to be a lot of changes in the stats package but it's mostly moving code around and renaming things as the code was confusing at some points due to poor naming.

I intend to deploy this in our staging environment and develop some alerts there that I can then add as examples in this repo.

/kind feature
/priority important-longterm
/assign

[roivaz]

/ok-to-test

[slopezz]

/lgtm

[3scale-robot]

LGTM label has been added.

Git tree hash: 4954e2c4bbb6e788dfa13390cac1c00caa070cd4

[roivaz]

/approve

[3scale-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roivaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment