Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from operator-utils to 3scale-ops/basereconciler #174

Merged
merged 8 commits into from
Apr 4, 2023
Merged

switch from operator-utils to 3scale-ops/basereconciler #174

merged 8 commits into from
Apr 4, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Mar 30, 2023 •
edited
Loading

This PR replaces the operator-utils lockedresource reconciler by our own basereconciler for DiscoveryService and EnvoyDeployment controllers, which has been extracted from the saas-operator and converted into a standalone module. This change should also fix #164

/kind feature
/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added do-not-merge/work-in-progress needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. labels Mar 30, 2023
@roivaz
Copy link
Member Author

roivaz commented Mar 30, 2023

/ok-to-test

@3scale-robot 3scale-robot added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Requires few days to complete the PR or the issue. labels Mar 30, 2023
@3scale-robot 3scale-robot removed the needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. label Mar 30, 2023
@roivaz roivaz added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 3, 2023
@roivaz
Copy link
Member Author

roivaz commented Apr 4, 2023

/retitle switch from operator-ituls to 3scale-ops/basereconciler

@3scale-robot 3scale-robot changed the title WIP - basereconciler switch from operator-ituls to 3scale-ops/basereconciler Apr 4, 2023
@roivaz roivaz changed the title switch from operator-ituls to 3scale-ops/basereconciler switch from operator-utils to 3scale-ops/basereconciler Apr 4, 2023
@roivaz roivaz added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 4, 2023
@raelga
Copy link
Contributor

raelga commented Apr 4, 2023

/kind feature
/priority important-longterm
/lgtm

@3scale-robot 3scale-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 4, 2023
@3scale-robot 3scale-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. lgtm Indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. labels Apr 4, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d72851b70218595455b1703fbf1f6b3e69da274

@3scale-robot 3scale-robot removed the needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. label Apr 4, 2023
@roivaz
Copy link
Member Author

roivaz commented Apr 4, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@3scale-robot 3scale-robot merged commit 43487fc into main Apr 4, 2023
@3scale-robot 3scale-robot deleted the feat/reconcile-utils branch April 4, 2023 09:10
@roivaz roivaz mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/L Requires few days to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slow reconcilliation of EnvoyDeployment and DiscoveryService
3 participants
@roivaz @raelga @3scale-robot