-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource specification for EnvoyConfig custom resources #177
Conversation
/ok-to-test |
28a2098
to
b024a1c
Compare
8423d29
to
04bc809
Compare
Add a new field `spec.resources` that allows to better express envoy resources. Internally, all the code uses now this field instead of `spec.envoyResources`. The old field still works as it is transparently converted by the controller to the new format. The API has also been extended to support endpoint discovery from k8s EndpointSlices and to support validationContext secret types. None of those features are implemented yet.
/retitle New resource specification for EnvoyConfig custom resources |
/lgtm |
LGTM label has been added. Git tree hash: 408bf726077a1138368c007d71778c7fa58c3f80
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR changes the way that resources are specified in the EnvoyConfig custom resource. A new field
spec.resources
has been added that is meant to replacespec.envoyResources
. Both fields and specification formats work currently, with the controller internally transforming fromspec.envoyResources
tospec.resources
.The new resource specification looks like this:
Some other updates also in this PR, like upgrade of go-control-plane, controller-runtime, etc.
/kind feature
/priority important-soon
/assign