Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the 'validationContext' secret blueprint #183

Merged
merged 1 commit into from
May 18, 2023
Merged

Implement the 'validationContext' secret blueprint #183

merged 1 commit into from
May 18, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented May 17, 2023

Implements the feature request at #169

/kind feature
/priority important-longterm
/assign

@3scale-robot 3scale-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2023
@3scale-robot 3scale-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. labels May 17, 2023
@3scale-robot 3scale-robot removed the needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. label May 17, 2023
@slopezz
Copy link
Member

slopezz commented May 17, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8226e249237cb557ee7f058ab22ddabd12e83b20

@roivaz
Copy link
Member Author

roivaz commented May 17, 2023

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 17, 2023
@roivaz
Copy link
Member Author

roivaz commented May 18, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@3scale-robot 3scale-robot merged commit 3ce88df into main May 18, 2023
7 checks passed
@3scale-robot 3scale-robot deleted the feat/validation-context branch May 18, 2023 10:38
@roivaz roivaz mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roivaz @slopezz @3scale-robot