Harden requirements for taint #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/bug
3scale-robot
added
ok-to-test
|
/lgtm |
|
LGTM label has been added. Git tree hash: e24c51acd5420e89789341e7ff226c7c038c9ce0
|
3scale-robot
approved these changes
May 22, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR raises the number of NACKs required to consider an envoy Pod as failing to 5. So far, a single failure was enough to mark a pod as failing to load a given configuration revision. This was problematic when running a single pod setup, where a single failure would cause a revision to get tainted.
The change also has the side effect of making the taint process much slower, due to the fact that we now must wait for 5 failures and there's an exponential backoff mechanism in place when failures occur. To improve this a bit I have reduced the periodic reconcile of EnvoyConfigRevisions to 30 seconds.
/kind bug
/priority important-soon
/assign
/ok-to-test