Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix envoydeployment constant reconcile #194

Merged
merged 2 commits into from
May 31, 2023
Merged

Fix envoydeployment constant reconcile #194

merged 2 commits into from
May 31, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented May 30, 2023

Quick fix to solve a constant diff & reconcile in the envoydeployment controller.

/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels May 30, 2023
@3scale-robot 3scale-robot added size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels May 30, 2023
@roivaz
Copy link
Member Author

roivaz commented May 30, 2023

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 30, 2023
@slopezz
Copy link
Member

slopezz commented May 30, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c4dd89d85523a336e4db59a995d8046ece9b405

@roivaz
Copy link
Member Author

roivaz commented May 31, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@3scale-robot 3scale-robot merged commit 2a5a03e into main May 31, 2023
8 checks passed
@3scale-robot 3scale-robot deleted the fix-envoydeployment-constant-reconcile branch May 31, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roivaz @slopezz @3scale-robot