Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split each marin3r subcommand into its own file for clarity #97

Merged
merged 1 commit into from
May 17, 2021
Merged

Split each marin3r subcommand into its own file for clarity #97

merged 1 commit into from
May 17, 2021

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented May 17, 2021

This PR just splits the code in main.go so each subcommand has its own file inside the cmd package. No functionality is added.

/priority important-longterm
/kind cleanup
/assign

@3scale-robot 3scale-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 17, 2021
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels May 17, 2021
raelga
raelga approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 813b3e996e5fdd7a3f1a1ea3caa4eeacf097130e

@roivaz
Copy link
Member Author

roivaz commented May 17, 2021

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 17, 2021
@roivaz
Copy link
Member Author

roivaz commented May 17, 2021

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@3scale-robot 3scale-robot merged commit 1c747a5 into main May 17, 2021
@3scale-robot 3scale-robot deleted the feat/split-subcommands branch May 17, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@slopezz slopezz slopezz approved these changes

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/L Requires few days to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roivaz @3scale-robot @raelga @slopezz