Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod.rs to not require api_backend and endpoint #29

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Oct 12, 2022

As far as I know, api_backend is no longer a required field, this causes problems as it simply cannot deserialize a response that doesn't contain it.

Sadly I am not very versed in rust and so this the best I could do, I could make it a Option because of custom serializer.

@pehala pehala changed the title Update mod.rs to not require api_backend Update mod.rs to not require api_backend and endpoint Oct 21, 2022
@pehala
Copy link
Contributor Author

pehala commented Oct 21, 2022

Found another property not present in every production config (endpoint: null). It would be great if we had some authoritative answer on which properties are always present, but I do not think that is possible.

I also found a better way how to make them optional other than remove it.

@eguzki eguzki merged commit 51c6065 into 3scale-rs:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants