Jira SO-19: Remove non-groupified APIs in openshift/library templates #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
/cc @yselkowitz |
|
The patch itself LGTM, but I wonder if this template and imagestream are still supported on OCP4, where I would expect the operator would be used instead. The documentation is ambiguous on this point. Hopefully a maintainer can answer that question. |
|
Templates are only supported for OCP 3.11 On OCP4 the operator based installation is supported |
|
Does that apply to apicast as well? The docs are clear on 3scale templates vs operator but not so clear on apicast. |
|
Yes. For apicast standalone (or self-managed) there is the apicast operator for deployments in OCP 4 |
|
The 3scale and apicast templates have both been removed from OCP 4.11. This change is no longer strictly necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-groupified APIs were deprecated in OCP 4.7.
This PR only handles the imagestreams/Templates which are bundled in OpenShift. If any of the other imagestreams or templates are meant to still be used, they should also be similarly updated. A complete API list is available at https://docs.openshift.com/container-platform/4.10/rest_api/index.html
Signed-off-by: Feny Mehta fbm3307@gmail.com