Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metering Labels #367

Merged
merged 16 commits into from
Jun 8, 2020
Merged

Metering Labels #367

merged 16 commits into from
Jun 8, 2020

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented May 22, 2020 •
edited

Metering labels

https://docs.google.com/document/d/1bd9VnZ9jKwDBOOKAJltAtvhz3COUYYmRe3-BGE6fDGE/edit?ts=5de56bf6

  • 3scale-operator
  • apicast-production
  • apicast-staging
  • backend-cron
  • backend-listener
  • backend-redis
  • backend-worker
  • system-app
  • system-memcache
  • system-mysql
  • system-postgresql         
  • system-redis
  • system-sidekiq
  • system-sphinx
  • zync
  • zync-database
  • zync-que

@eguzki
Copy link
Member Author

eguzki commented May 22, 2020

Implemented first for apicast deployment.

@miguelsorianod Let's verify implementation before going for other deployments.

@eguzki eguzki force-pushed the metering-labels branch 3 times, most recently from 8253fad to d284a4a Compare May 23, 2020 16:17
miguelsorianod
miguelsorianod suggested changes May 25, 2020
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me 👍 . Left some feedback regarding naming / potential deduplication

@eguzki eguzki assigned miguelsorianod and unassigned eguzki May 25, 2020
@eguzki
Copy link
Member Author

eguzki commented May 25, 2020

resolved duplication issues.

@miguelsorianod
Copy link
Contributor

Looks good, it can be applied to others 👍

@eguzki eguzki force-pushed the metering-labels branch 2 times, most recently from adfaffb to 79b2884 Compare May 27, 2020 10:26
@eguzki eguzki marked this pull request as ready for review May 28, 2020 12:51
@eguzki eguzki assigned miguelsorianod and unassigned eguzki May 28, 2020
@eguzki
Copy link
Member Author

eguzki commented May 28, 2020

ready for review @miguelsorianod

miguelsorianod
miguelsorianod suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. I left some feedback

This was referenced Jun 3, 2020
Merged
Merged
@eguzki eguzki assigned eguzki and unassigned miguelsorianod Jun 4, 2020
@eguzki eguzki assigned miguelsorianod and unassigned eguzki Jun 4, 2020
@miguelsorianod
Copy link
Contributor

Applied changes look good to me 👍

I noticed another change and I left feedback on it.

@codeclimate
Copy link

codeclimate bot commented Jun 8, 2020

Code Climate has analyzed commit 5c9ebb4 and detected 65 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 48
Style 12

View more on Code Climate.

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Jun 8, 2020
@eguzki
Copy link
Member Author

eguzki commented Jun 8, 2020

All changes applied and feedback answered

miguelsorianod
miguelsorianod approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@eguzki eguzki merged commit fdbb4da into master Jun 8, 2020
@eguzki eguzki deleted the metering-labels branch June 8, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Assignees

@miguelsorianod miguelsorianod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eguzki @miguelsorianod