Increase pvc size

[eguzki]

Increase PVC resource request:

• system shared storage: 10Gi
• Redis system: 10Gi
• Redis backend: 10Gi
• System mysql: 10Gi
• System postgresql: 10Gi

[eguzki]

Warning for the upgrading path:

only dynamically provisioned pvc can be resized and the storageclass that provisions the pvc must support resize

Otherwise upgrade path might fail. Should the operator provide upgrade path? Can be checked if pvc has been provisioned dinamically AND the storageclass suppports resize?

[miguelsorianod]

I seem to remember there were some comparison methods that checked unexported fields, and that made detecting differences due to different internal representations of the same value depending on the serialized value. Have we checked this is working as expected in all cases?

That's why helper.CmpResources was created in its day for other kind of resources. I don't remember whether CmpResources takes into account ResourceStorage though

[eguzki]

CmpResources does not take into account ResourceStorage. Already checked it.

The upgrade logic uses Quantity type comparator, which I expect to be working

func main() {
	desired := resource.MustParse("10Gi")
	existing := resource.MustParse("1Gi")
	fmt.Println("desired == existing", existing.Cmp(desired) == 0)
	existing = resource.MustParse("10Gi")
	fmt.Println("desired == existing", existing.Cmp(desired) == 0)
}

desired == existing false
desired == existing true

[miguelsorianod]

Warning for the upgrading path:

only dynamically provisioned pvc can be resized and the storageclass that provisions the pvc must support resize

Otherwise upgrade path might fail. Should the operator provide upgrade path? Can be checked if pvc has been provisioned dinamically AND the storageclass suppports resize?

That's a concerning issue yes...

I'm also concerned about increasing x10 storage requirements of a 3scale installation.

Let's talk about this a little bit through other channels.

[codeclimate]

Code Climate has analyzed commit 1cdb3c2 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1
Style	5

View more on Code Climate.

[eguzki]

Closing this issue as:

• the upgrading path may fail and there is no way to prevent it
• Initial required storage size can be up to 40Gb, which can be too much

A better way to go is:

• allow "install only" configuration of storage size
• allow linking PV provisioned by the customer by name (thus no storage size is needed)