Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIcast workers monitoring alert #484

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

miguelsorianod
Copy link
Contributor

As requested in https://issues.redhat.com/browse/THREESCALE-6047.

I've adapted the provided alert with some filtering changes and naming changes

@miguelsorianod
Copy link
Contributor Author

Let me know if expr and the other parts make sense

@miguelsorianod miguelsorianod force-pushed the add-apicast-workers-monitoring-alert branch from bbbb02d to d23c17a Compare October 1, 2020 16:31
pkg/3scale/amp/component/apicast_monitoring.go Outdated Show resolved Hide resolved
pkg/3scale/amp/component/apicast_monitoring.go Outdated Show resolved Hide resolved
pkg/3scale/amp/component/apicast_monitoring.go Outdated Show resolved Hide resolved
pkg/3scale/amp/component/apicast_monitoring.go Outdated Show resolved Hide resolved
pkg/3scale/amp/component/apicast_monitoring.go Outdated Show resolved Hide resolved
@miguelsorianod miguelsorianod force-pushed the add-apicast-workers-monitoring-alert branch 2 times, most recently from eb45ed6 to 9728082 Compare October 2, 2020 14:29
@eguzki eguzki assigned eloycoto and unassigned eguzki Oct 5, 2020
@miguelsorianod miguelsorianod force-pushed the add-apicast-workers-monitoring-alert branch from 9728082 to 4aee5bd Compare October 6, 2020 10:51
@miguelsorianod miguelsorianod force-pushed the add-apicast-workers-monitoring-alert branch from 4aee5bd to 59bb12a Compare October 6, 2020 10:51
@codeclimate
Copy link

codeclimate bot commented Oct 6, 2020

Code Climate has analyzed commit 59bb12a and detected 0 issues on this pull request.

View more on Code Climate.

@miguelsorianod miguelsorianod merged commit 4aa98f2 into master Oct 6, 2020
@miguelsorianod miguelsorianod deleted the add-apicast-workers-monitoring-alert branch October 6, 2020 12:21
@obrienrobert
Copy link

@eloycoto @miguelsorianod I've had some discussion/received some feedback from CS-SRE in relation to this alert, the outcome of which is that this alert should be a warning, as opposed to a critical. The reason for this is that a worker process restart can be the caused by something other than a OOM, but SRE will still get notified.

Would it be possible to downgrade the severity of this alert to warning, please?

@miguelsorianod
Copy link
Contributor Author

ok @obrienrobert,

I'll open a new PR to change it.

@miguelsorianod
Copy link
Contributor Author

Changed in #488

eloycoto added a commit to eloycoto/3scale-Operations that referenced this pull request Oct 8, 2020
This is the SOP for worker restart limit.

Related to:
3scale/3scale-operator#484
3scale/APIcast#1228
https://issues.redhat.com/browse/THREESCALE-5965

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto added a commit to eloycoto/3scale-Operations that referenced this pull request Oct 8, 2020
This is the SOP for worker restart limit.

Related to:
3scale/3scale-operator#484
3scale/APIcast#1228
https://issues.redhat.com/browse/THREESCALE-5965

Fix THREESCALE-6119
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto added a commit to eloycoto/3scale-Operations that referenced this pull request Oct 14, 2020
This is the SOP for worker restart limit.

Related to:
3scale/3scale-operator#484
3scale/APIcast#1228
https://issues.redhat.com/browse/THREESCALE-5965

Fix THREESCALE-6119
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto added a commit to 3scale/3scale-Operations that referenced this pull request Oct 14, 2020
This is the SOP for worker restart limit.

Related to:
3scale/3scale-operator#484
3scale/APIcast#1228
https://issues.redhat.com/browse/THREESCALE-5965

Fix THREESCALE-6119
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants