Rename APIcast openTracing.tracingConfigRef to tracingConfigSecretRef #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be backported to 2.11-candidate and 2.11-stable. QE is aware of this |
miguelsorianod
force-pushed
the
rename-tracingconfigsecretref
branch
from
36b9e46
to
6722d33
Compare
miguelsorianod
force-pushed
the
rename-tracingconfigsecretref
branch
from
6722d33
to
2c2ced9
Compare
|
Code Climate has analyzed commit 2c2ced9 and detected 0 issues on this pull request. View more on Code Climate. |
eguzki
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename .spec.openTracing.tracingConfigRef to .spec.openTracing.tracingConfigSecretRef to better indicate that the config to be provided is a K8s secret. Used in APIcast production and staging