New metering labels

[eguzki]

https://issues.redhat.com/browse/THREESCALE-7750

Spec doc: https://docs.google.com/document/d/1bd9VnZ9jKwDBOOKAJltAtvhz3COUYYmRe3-BGE6fDGE/edit#bookmark=id.27cia5h5kj9j

example of one pod

❯ k get pods apicast-production-1-stm67 -o jsonpath="{.metadata.labels}" | jq '.'
{
  "app": "3scale-api-management",
  "deployment": "apicast-production-1",
  "deploymentConfig": "apicast-production",
  "deploymentconfig": "apicast-production",
  "rht.comp": "3scale",
  "rht.comp_ver": "master",
  "rht.prod_name": "Red_Hat_Integration",
  "rht.prod_ver": "master", 
  "rht.subcomp": "apicast-production",
  "rht.subcomp_t": "application",
  "threescale_component": "apicast",
  "threescale_component_element": "production"
}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[eguzki]

ready for review @miguelsorianod

[miguelsorianod]

With this changes here we will ensure new labels are added, but the old labels will still be there. Should we clean them too?

[eguzki]

Added procedure to remove old labels

[miguelsorianod]

This method will need to be reused in future 3scale versions, without the part that removes the old metering labels. If you want you can add a comment to remember to delete that part

[eguzki]

done

[miguelsorianod]

I left some comments. Overall it looks good 👍

[eguzki]

/retest

[miguelsorianod]

We will need to be careful when preparing the 2.12 candidate and stable branches about this value too

[miguelsorianod]

I left a minor comment. Looks good to me

[codeclimate]

Code Climate has analyzed commit 1447c1c and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2
Duplication	2
Style	1

View more on Code Climate.