Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix circleci tests #765

Merged
merged 1 commit into from Jun 21, 2022
Merged

fix circleci tests #765

merged 1 commit into from Jun 21, 2022

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Jun 21, 2022

Unittest memory footpring increased up to 7.5 GB and requires large resource class.

#742 (comment)

Opened issue to try to fix the memory footpring: https://issues.redhat.com/browse/THREESCALE-8493

@codeclimate
Copy link

codeclimate bot commented Jun 21, 2022

Code Climate has analyzed commit f7595c6 and detected 0 issues on this pull request.

View more on Code Climate.

@MStokluska
Copy link
Contributor

code changes looks good to me, as I understand it it's a temp solution while the https://issues.redhat.com/browse/THREESCALE-8493 is going to be investigated.
/lgtm

@eguzki
Copy link
Member Author

eguzki commented Jun 21, 2022

code changes looks good to me, as I understand it it's a temp solution while the https://issues.redhat.com/browse/THREESCALE-8493 is going to be investigated. /lgtm

exactly. If we can reduce the memory footpring, large resource class will not be necessary. I am pretty confident we can. 7.5 Gb does not make sense.

@eguzki
Copy link
Member Author

eguzki commented Jun 21, 2022

@MStokluska hit "approve" in "files changed"

@eguzki eguzki merged commit 5be3d33 into master Jun 21, 2022
@eguzki eguzki deleted the fix-circleci-tests branch June 21, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants