Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ProxyConfigPromote status when the product not found #774

Conversation

austincunningham
Copy link
Contributor

@austincunningham austincunningham commented Aug 5, 2022

WHAT

update the status in ProxyConfigPromote if the Product is not found

Verification

  1. Deploy 3scale-operator locally
  2. Create dummy smtp secret
kubectl apply -f - <<EOF
---
kind: Secret
apiVersion: v1
metadata: 
  name: s3-credentials
  namespace: 3scale-test
data: 
  AWS_ACCESS_KEY_ID: UkVQTEFDRV9NRQ==
  AWS_BUCKET: UkVQTEFDRV9NRQ==
  AWS_REGION: UkVQTEFDRV9NRQ==
  AWS_SECRET_ACCESS_KEY: UkVQTEFDRV9NRQ==
type: Opaque
EOF

3.Create apimanager resource

kubectl apply -f - <<EOF
---
apiVersion: apps.3scale.net/v1alpha1
kind: APIManager
metadata: 
  name: apimanager-sample
  namespace: 3scale-test
spec: 
  system: 
    fileStorage: 
      simpleStorageService: 
        configurationSecretRef: 
          name: s3-credentials
  wildcardDomain: <cluster_domain>
EOF
  1. As no products exist create proxyconfigpromote resource to promote non existing product to staging.
kubectl apply -f - <<EOF
---
apiVersion: capabilities.3scale.net/v1beta1
kind: ProxyConfigPromote
metadata:
  name: product1-v1-staging
  namespace: 3scale-test
spec:
  productCRName: product1-cr-wrong-name
EOF
  1. Confirm that the status updates as follows e.g.
status:
  conditions:
    - lastTransitionTime: '2022-08-05T10:58:44Z'
      status: 'False'
      type: Ready
  productId: product not found

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

Hi @austincunningham. Thanks for your PR.

I'm waiting for a 3scale member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@austincunningham austincunningham force-pushed the Threescale-7135-update-status-product-not-found branch from 8384747 to 08cd548 Compare August 5, 2022 11:34
@austincunningham austincunningham force-pushed the Threescale-7135-update-status-product-not-found branch from 08cd548 to a370bcd Compare August 5, 2022 11:37
@austincunningham austincunningham changed the title Update the status when the product not found Update the ProxyConfigPromote status when the product not found Aug 5, 2022
@austincunningham austincunningham force-pushed the Threescale-7135-update-status-product-not-found branch from a370bcd to 6732182 Compare August 5, 2022 11:48
@codeclimate
Copy link

codeclimate bot commented Aug 5, 2022

Code Climate has analyzed commit 6732182 and detected 0 issues on this pull request.

View more on Code Climate.

@Patryk-Stefanski
Copy link
Contributor

/ok-to-test

@austincunningham
Copy link
Contributor Author

/test test-e2e

Copy link
Member

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verification steps passed

@eguzki eguzki merged commit e74f120 into 3scale:master Aug 17, 2022
@austincunningham
Copy link
Contributor Author

@eguzki if you have time for a review

@austincunningham
Copy link
Contributor Author

I should hit refresh on my browser once in a while

@eguzki
Copy link
Member

eguzki commented Aug 19, 2022

two days with the browser opened with a tab with this PR opened, wow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants