Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREESCALE-9984: go1.19 #844

Merged
merged 1 commit into from
Jul 21, 2023
Merged

THREESCALE-9984: go1.19 #844

merged 1 commit into from
Jul 21, 2023

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Jul 21, 2023

@eguzki eguzki requested a review from a team as a code owner July 21, 2023 11:22
@codeclimate
Copy link

codeclimate bot commented Jul 21, 2023

Code Climate has analyzed commit ea41be1 and detected 0 issues on this pull request.

View more on Code Climate.

@eguzki
Copy link
Member Author

eguzki commented Jul 21, 2023

@austincunningham review of this PR as well about the e2e framework openshift/release#41527

@austincunningham
Copy link
Contributor

Verification

  • Checkout this branch
  • Change to go1.19 locally
  • Ran go mod tidy & go mod vendor
  • ran make install
make install
/home/austincunningham/repo-integr8ly/3scale-operator/bin/controller-gen "crd:crdVersions=v1" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/austincunningham/repo-integr8ly/3scale-operator/bin/kustomize build config/crd | kubectl create -f - || /home/austincunningham/repo-integr8ly/3scale-operator/bin/kustomize build config/crd | kubectl replace -f -
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "activedocs.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "apimanagerbackups.apps.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "apimanagerrestores.apps.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "apimanagers.apps.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "applications.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "backends.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "custompolicydefinitions.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "developeraccounts.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "developerusers.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "openapis.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "products.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "proxyconfigpromotes.capabilities.3scale.net" already exists
Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "tenants.capabilities.3scale.net" already exists
customresourcedefinition.apiextensions.k8s.io/activedocs.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/apimanagerbackups.apps.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/apimanagerrestores.apps.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/apimanagers.apps.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/applications.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/backends.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/custompolicydefinitions.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/developeraccounts.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/developerusers.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/openapis.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/products.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/proxyconfigpromotes.capabilities.3scale.net replaced
customresourcedefinition.apiextensions.k8s.io/tenants.capabilities.3scale.net replaced
  • ran make run no runtime errors
 make run
/home/austincunningham/repo-integr8ly/3scale-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
Generate Go embedded assets files by processing source
export PATH=/home/austincunningham/repo-integr8ly/3scale-operator/bin:$PATH;    go generate github.com/3scale/3scale-operator/pkg/assets
go fmt ./...
pkg/assets/bindata.go
go vet ./...
/home/austincunningham/repo-integr8ly/3scale-operator/bin/controller-gen "crd:crdVersions=v1" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
go run ./main.go --zap-devel
1.6899465509077468e+09  INFO    setup   Operator Version: 0.11.0
1.6899465509077618e+09  INFO    setup   Go Version: go1.19
1.689946550907765e+09   INFO    setup   Go OS/Arch: linux/amd64
I0721 14:35:52.172478 1598780 request.go:601] Waited for 1.049688575s due to client-side throttling, not priority and fairness, request: GET:https://api.aucunnin-ccs.edy6.s1.devshift.org:6443/apis/performance.openshift.io/v1?timeout=32s
1.6899465542062795e+09  INFO    controller-runtime.metrics      Metrics server is starting to listen    {"addr": ":8080"}
1.6899465542090333e+09  INFO    setup   starting manager
1.6899465542094815e+09  INFO    Starting server {"path": "/metrics", "kind": "metrics", "addr": "[::]:8080"}
1.6899465542097204e+09  INFO    Starting EventSource    {"controller": "apimanager", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManager", "source": "kind source: *v1alpha1.APIManager"}
1.6899465542098114e+09  INFO    Starting EventSource    {"controller": "apimanagerbackup", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManagerBackup", "source": "kind source: *v1alpha1.APIManagerBackup"}
1.68994655420992e+09    INFO    Starting EventSource    {"controller": "apimanager", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManager", "source": "kind source: *v1.DeploymentConfig"}
1.6899465542099419e+09  INFO    Starting Controller     {"controller": "apimanagerbackup", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManagerBackup"}
1.6899465542099707e+09  INFO    Starting EventSource    {"controller": "apimanager", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManager", "source": "kind source: *v1.Route"}
1.689946554210006e+09   INFO    Starting Controller     {"controller": "apimanager", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManager"}
1.6899465542099197e+09  INFO    Starting EventSource    {"controller": "apimanagerrestore", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManagerRestore", "source": "kind source: *v1alpha1.APIManagerRestore"}
1.6899465542101004e+09  INFO    Starting EventSource    {"controller": "apimanagerrestore", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManagerRestore", "source": "kind source: *v1.Pod"}
1.68994655421001e+09    INFO    Starting EventSource    {"controller": "route", "controllerGroup": "route.openshift.io", "controllerKind": "Route", "source": "kind source: *v1.Route"}
1.6899465542100499e+09  INFO    Starting EventSource    {"controller": "openapi", "controllerGroup": "capabilities.3scale.net", "controllerKind": "OpenAPI", "source": "kind source: *v1beta1.OpenAPI"}
1.6899465542102096e+09  INFO    Starting Controller     {"controller": "route", "controllerGroup": "route.openshift.io", "controllerKind": "Route"}
1.6899465542102294e+09  INFO    Starting Controller     {"controller": "openapi", "controllerGroup": "capabilities.3scale.net", "controllerKind": "OpenAPI"}
1.68994655421015e+09    INFO    Starting Controller     {"controller": "apimanagerrestore", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManagerRestore"}
1.689946554210087e+09   INFO    Starting EventSource    {"controller": "activedoc", "controllerGroup": "capabilities.3scale.net", "controllerKind": "ActiveDoc", "source": "kind source: *v1beta1.ActiveDoc"}
1.689946554210335e+09   INFO    Starting Controller     {"controller": "activedoc", "controllerGroup": "capabilities.3scale.net", "controllerKind": "ActiveDoc"}
1.6899465542102067e+09  INFO    Starting EventSource    {"controller": "product", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Product", "source": "kind source: *v1beta1.Product"}
1.6899465542104108e+09  INFO    Starting Controller     {"controller": "product", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Product"}
1.689946554210387e+09   INFO    Starting EventSource    {"controller": "backend", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Backend", "source": "kind source: *v1beta1.Backend"}
1.6899465542104855e+09  INFO    Starting Controller     {"controller": "backend", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Backend"}
1.689946554210329e+09   INFO    Starting EventSource    {"controller": "custompolicydefinition", "controllerGroup": "capabilities.3scale.net", "controllerKind": "CustomPolicyDefinition", "source": "kind source: *v1beta1.CustomPolicyDefinition"}
1.689946554210588e+09   INFO    Starting Controller     {"controller": "custompolicydefinition", "controllerGroup": "capabilities.3scale.net", "controllerKind": "CustomPolicyDefinition"}
1.6899465542105944e+09  INFO    Starting EventSource    {"controller": "tenant", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Tenant", "source": "kind source: *v1alpha1.Tenant"}
1.6899465542107325e+09  INFO    Starting Controller     {"controller": "tenant", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Tenant"}
1.6899465542106285e+09  INFO    Starting EventSource    {"controller": "developeraccount", "controllerGroup": "capabilities.3scale.net", "controllerKind": "DeveloperAccount", "source": "kind source: *v1beta1.DeveloperAccount"}
1.689946554210751e+09   INFO    Starting EventSource    {"controller": "proxyconfigpromote", "controllerGroup": "capabilities.3scale.net", "controllerKind": "ProxyConfigPromote", "source": "kind source: *v1beta1.ProxyConfigPromote"}
1.6899465542108672e+09  INFO    Starting Controller     {"controller": "developeraccount", "controllerGroup": "capabilities.3scale.net", "controllerKind": "DeveloperAccount"}
1.6899465542108898e+09  INFO    Starting Controller     {"controller": "proxyconfigpromote", "controllerGroup": "capabilities.3scale.net", "controllerKind": "ProxyConfigPromote"}
1.6899465542109714e+09  INFO    Starting EventSource    {"controller": "developeruser", "controllerGroup": "capabilities.3scale.net", "controllerKind": "DeveloperUser", "source": "kind source: *v1beta1.DeveloperUser"}
1.6899465542110062e+09  INFO    Starting EventSource    {"controller": "application", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Application", "source": "kind source: *v1beta1.Application"}
1.6899465542111182e+09  INFO    Starting Controller     {"controller": "developeruser", "controllerGroup": "capabilities.3scale.net", "controllerKind": "DeveloperUser"}
1.6899465542111673e+09  INFO    Starting Controller     {"controller": "application", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Application"}
1.689946554311977e+09   INFO    Starting workers        {"controller": "product", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Product", "worker count": 1}
1.6899465543131025e+09  INFO    Starting workers        {"controller": "developeraccount", "controllerGroup": "capabilities.3scale.net", "controllerKind": "DeveloperAccount", "worker count": 1}
1.6899465543132534e+09  INFO    Starting workers        {"controller": "backend", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Backend", "worker count": 1}
1.6899465543155246e+09  INFO    Starting workers        {"controller": "activedoc", "controllerGroup": "capabilities.3scale.net", "controllerKind": "ActiveDoc", "worker count": 1}
1.689946554315648e+09   INFO    Starting workers        {"controller": "openapi", "controllerGroup": "capabilities.3scale.net", "controllerKind": "OpenAPI", "worker count": 1}
1.6899465543180132e+09  INFO    Starting workers        {"controller": "custompolicydefinition", "controllerGroup": "capabilities.3scale.net", "controllerKind": "CustomPolicyDefinition", "worker count": 1}
1.6899465543180807e+09  INFO    Starting workers        {"controller": "route", "controllerGroup": "route.openshift.io", "controllerKind": "Route", "worker count": 1}
1.6899465543181338e+09  INFO    Starting workers        {"controller": "apimanager", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManager", "worker count": 1}
1.6899465543181303e+09  INFO    Starting workers        {"controller": "apimanagerbackup", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManagerBackup", "worker count": 1}
1.6899465543181467e+09  INFO    Starting workers        {"controller": "tenant", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Tenant", "worker count": 1}
1.6899465543193784e+09  INFO    Starting workers        {"controller": "developeruser", "controllerGroup": "capabilities.3scale.net", "controllerKind": "DeveloperUser", "worker count": 1}
1.689946554319441e+09   INFO    Starting workers        {"controller": "apimanagerrestore", "controllerGroup": "apps.3scale.net", "controllerKind": "APIManagerRestore", "worker count": 1}
1.6899465543194437e+09  INFO    Starting workers        {"controller": "proxyconfigpromote", "controllerGroup": "capabilities.3scale.net", "controllerKind": "ProxyConfigPromote", "worker count": 1}
1.6899465543194861e+09  INFO    Starting workers        {"controller": "application", "controllerGroup": "capabilities.3scale.net", "controllerKind": "Application", "worker count": 1}

/lgtm

@eguzki eguzki merged commit abd9bc7 into master Jul 21, 2023
14 checks passed
@eguzki eguzki deleted the bump-go-1.19 branch July 21, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants