THREESCALE-7864 set async by default on backend work

[austincunningham]

Jira

THREESCALE-7864

What

set async by default on backend work

Verification

• Create a project oc new-project 3scale-test
• make install
• make run
• Create a s3 secret

kubectl apply -f - <<EOF
---
kind: Secret
apiVersion: v1
metadata:
  name: s3-credentials
data:
  AWS_ACCESS_KEY_ID: UkVQTEFDRV9NRQ==
  AWS_BUCKET: UkVQTEFDRV9NRQ==
  AWS_REGION: UkVQTEFDRV9NRQ==
  AWS_SECRET_ACCESS_KEY: UkVQTEFDRV9NRQ==
type: Opaque
EOF

• Create an apimanager CR using that secret e.g.

kubectl apply -f - <<EOF
---
apiVersion: apps.3scale.net/v1alpha1
kind: APIManager
metadata:
  name: apimanager-sample
spec:
  system:
    fileStorage:
      simpleStorageService:
        configurationSecretRef:
          name: s3-credentials
  wildcardDomain: apps.aucunnin.wx3t.s1.devshift.org
EOF

• Check the backend work pod for the CONFIG_REDIS_ASYNC envar

$ oc get po | grep backend-worker
backend-worker-1-deploy       0/1     Completed   0             12m
backend-worker-1-jn29j        1/1     Running     0             12m
$ oc exec backend-worker-1-jn29j -- env | grep CONFIG_REDIS_ASYNC
Defaulted container "backend-worker" out of: backend-worker, backend-redis-svc (init)
CONFIG_REDIS_ASYNC=1

• remove the envar from the backend-worker deployment config spec.containers.env and see if its reconciled back e.g. remove this

- name: CONFIG_REDIS_ASYNC
  value: '1'

[carlkyrillos]

Reviewed code changes and completed verification steps
/lgtm

[codeclimate]

Code Climate has analyzed commit b3f3fc9 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.

[MStokluska]

/lgtm

Going to lgtm, personally, I would still move the env mutator specific to worker to only be applied as part of worker mutators but leaving it up to Austin to decide. Thanks Austin!