THREESCALE-10709 update monitoring stack deployment to use THANOS_QUERIER_BEARER_TOKEN #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincunningham
force-pushed
the
THREESCALE-10709
branch
from
3c1bf58
to
5fe63e2
Compare
…RIER_BEARER_TOKEN
austincunningham
force-pushed
the
THREESCALE-10709
branch
from
5fe63e2
to
d00836d
Compare
carlkyrillos
reviewed
Feb 1, 2024
| $ SECRET=`oc get secret -n openshift-user-workload-monitoring | grep prometheus-user-workload-token | head -n 1 | awk '{print $1 }'` | ||
| # Get the THANOS_QUERIER_BEARER_TOKEN using the SECRET name | ||
| $ oc get secret $SECRET -n openshift-user-workload-monitoring -o jsonpath="{.data.token}" | base64 -d | ||
|
|
There was a problem hiding this comment.
Suggested change
Unnecessary extra line looks odd when markdown is rendered.
| Get basic auth password `basicAuthPassword` from `ns/openshift-monitoring/secrets/grafana-datasources-v2/prometheus.yaml` and update `3scale-scrape-configs.yaml` basic auth field. | ||
| ```bash | ||
| # Get the SECRET name that contains the THANOS_QUERIER_BEARER_TOKEN | ||
| $ SECRET=`oc get secret -n openshift-user-workload-monitoring | grep prometheus-user-workload-token | head -n 1 | awk '{print $1 }'` |
There was a problem hiding this comment.
Suggested change
| $ SECRET=`oc get secret -n openshift-user-workload-monitoring | grep prometheus-user-workload-token | head -n 1 | awk '{print $1 }'` | |
| SECRET=`oc get secret -n openshift-user-workload-monitoring | grep prometheus-user-workload-token | head -n 1 | awk '{print $1 }'` |
It makes it easier to run the commands if the leading $ is removed.
| # Get the SECRET name that contains the THANOS_QUERIER_BEARER_TOKEN | ||
| $ SECRET=`oc get secret -n openshift-user-workload-monitoring | grep prometheus-user-workload-token | head -n 1 | awk '{print $1 }'` | ||
| # Get the THANOS_QUERIER_BEARER_TOKEN using the SECRET name | ||
| $ oc get secret $SECRET -n openshift-user-workload-monitoring -o jsonpath="{.data.token}" | base64 -d |
There was a problem hiding this comment.
Suggested change
| $ oc get secret $SECRET -n openshift-user-workload-monitoring -o jsonpath="{.data.token}" | base64 -d | |
| oc get secret $SECRET -n openshift-user-workload-monitoring -o jsonpath="{.data.token}" | base64 -d |
It makes it easier to run the commands if the leading $ is removed.
|
|
||
| Then create secret: | ||
|
|
||
| ``` | ||
| ```bash | ||
| kubectl create secret generic additional-scrape-configs --from-file=3scale-scrape-configs.yaml=./3scale-scrape-configs.yaml |
There was a problem hiding this comment.
Suggested change
| kubectl create secret generic additional-scrape-configs --from-file=3scale-scrape-configs.yaml=./3scale-scrape-configs.yaml | |
| oc create secret generic additional-scrape-configs --from-file=3scale-scrape-configs.yaml=./3scale-scrape-configs.yaml |
Might be better to use oc here to be consistent throughout
|
Code Climate has analyzed commit e7a053b and detected 0 issues on this pull request. View more on Code Climate. |
|
Reviewed changes |
MStokluska
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://issues.redhat.com/browse/THREESCALE-10709
What
The steps for getting openshift monitoring data in the readme have been out of date for some time
You can no longer use basic auth to scrape data from openshift-monitoring see OCP docs for more information here
updated the 3scale-scrape-configs.yaml to use bearer token
added steps to the Readme to get the THANOS_QUERIER_BEARER_TOKEN
Verification
Provision a 3scale instance from this branch and follow the readme to test the monitoring stack installation.