THREESCALE-10937 update upstream db images #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const ( | ||
| redisDefaultImage = "quay.io/sclorg/redis-6-c8s" | ||
| mySqlDefaultImage = "quay.io/sclorg/mysql-80-c8s" | ||
| postgreSqlDefaultImage = "quay.io/sclorg/postgresql-10-c8s" |
There was a problem hiding this comment.
As the images are only used once I don't see the need to have them defined as consts. Just use the image strings
There was a problem hiding this comment.
I moved these to consts because it makes it easier to update (read the file when updating the images) and you don't have to be going through the file to find and update images.
There was a problem hiding this comment.
Prefer reading it the other way as I don't have to jump around a file to find out which image is used, but thats me. Personal preference. I will leave it up to you
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/THREESCALE-10937
Move the centos images to sclorg images since centos7 is no longer maintained.
Verification:
For MySQL and Redis e2e passing is enough
For PostgreSQL, pull the image locally to confirm it's available.