Merge pull request #349 from 3scale/remove-deprecated-update-command

remove deprecated update service command

README.md

@@ -91,7 +91,6 @@ COMMANDS
     proxy-config         proxy-config super command
     remote               remotes super command
     service              services super command
-    update               [DEPRECATED] update super command
 
 OPTIONS
     -c --config-file=<value>      3scale toolbox configuration file (default:
@@ -178,7 +177,6 @@ Then register the core command in `lib/3scale_toolbox/commands.rb`
 +++ b/lib/3scale_toolbox/commands.rb
 @@ -4,6 +4,7 @@ require '3scale_toolbox/commands/copy_command'
  require '3scale_toolbox/commands/import_command'
- require '3scale_toolbox/commands/update_command'
  require '3scale_toolbox/commands/remote_command'
 +require '3scale_toolbox/commands/service_list_command'
 
@@ -187,7 +185,6 @@ Then register the core command in `lib/3scale_toolbox/commands.rb`
 @@ -12,7 +13,8 @@ module ThreeScaleToolbox
        ThreeScaleToolbox::Commands::CopyCommand,
        ThreeScaleToolbox::Commands::ImportCommand,
-       ThreeScaleToolbox::Commands::UpdateCommand,
 -      ThreeScaleToolbox::Commands::RemoteCommand::RemoteCommand
 +      ThreeScaleToolbox::Commands::RemoteCommand::RemoteCommand,
 +      ThreeScaleToolbox::Commands::ServiceListCommand

lib/3scale_toolbox/commands.rb

@@ -2,7 +2,6 @@
 require '3scale_toolbox/commands/proxy_command'
 require '3scale_toolbox/commands/help_command'
 require '3scale_toolbox/commands/import_command'
-require '3scale_toolbox/commands/update_command'
 require '3scale_toolbox/commands/remote_command'
 require '3scale_toolbox/commands/plans_command'
 require '3scale_toolbox/commands/metrics_command'
@@ -24,7 +23,6 @@ module Commands
       ThreeScaleToolbox::Commands::HelpCommand,
       ThreeScaleToolbox::Commands::CopyCommand,
       ThreeScaleToolbox::Commands::ImportCommand,
-      ThreeScaleToolbox::Commands::UpdateCommand,
       ThreeScaleToolbox::Commands::RemoteCommand::RemoteCommand,
       ThreeScaleToolbox::Commands::PlansCommand,
       ThreeScaleToolbox::Commands::MetricsCommand,

spec/shared_contexts.rb

@@ -65,7 +65,9 @@ def get_plugin_content(command_class_name, command_name)
   let(:http_client) do
     ThreeScale::API::HttpClient.new(endpoint: endpoint,
                                     provider_key: provider_key,
-                                    verify_ssl: verify_ssl)
+                                    verify_ssl: verify_ssl,
+                                    keep_alive: true,
+                                   )
   end
 
   let(:api3scale_client) { ThreeScale::API::Client.new(http_client) }
@@ -89,23 +91,6 @@ def get_plugin_content(command_class_name, command_name)
     backend_usage_list.map(&:backend).each(&:delete)
     source_service.delete
 
-    #backend_usage_list = begin
-    #                       source_service.backend_usage_list
-    #                     rescue ThreeScale::API::HttpClient::NotFoundError
-    #                       []
-    #                     end
-    #backend_usage_list.map(&:backend).each do |backend|
-    #  Helpers.wait do
-    #    begin
-    #      backend.delete
-    #    rescue ThreeScale::API::HttpClient::NotFoundError
-    #      true
-    #    rescue ThreeScale::API::HttpClient::ForbiddenError
-    #      false
-    #    end
-    #  end
-    #end
-
     # delete target activedocs
     target_service.activedocs.each do |activedoc|
       target_service.remote.delete_activedocs(activedoc.id)