-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change type from int to float of the --cost-per-month and --setup-fee options #162
Conversation
This is a change that can only be tested in integration tests. Sadly, currently, integration tests for app plan CRUD commands are technical debt. |
@nmasse-itix travis CI tests did not report back. I cannot check because PR was done from forked repo. Can you check results? Sometimes tests pass and status report fails. We usually restart CI job and should be fixed. |
It seems I do not have the secrets to connect to the 3scale instance: |
I ran the integration tests manually against my own 3scale instance (
|
@nmasse-itix We plan to fix this issue and let PR's from forked repos. Meanwhile, exceptionally, I have tested locally this PR as well and passes. |
This PR fixes #156