Do not set skip_swagger_validation when not provided as an option in activedocs apply #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsorianod
force-pushed
the
fix-activedocs-swagger-validation-sideefects
branch
2 times, most recently
from
9aa0c5c
to
90a7fd4
Compare
|
Ready for review @eguzki |
miguelsorianod
force-pushed
the
fix-activedocs-swagger-validation-sideefects
branch
from
90a7fd4
to
7f7f1e9
Compare
miguelsorianod
changed the title
miguelsorianod
changed the title
miguelsorianod
force-pushed
the
fix-activedocs-swagger-validation-sideefects
branch
from
7f7f1e9
to
6a2dc3f
Compare
eguzki
requested changes
Dec 3, 2019
miguelsorianod
force-pushed
the
fix-activedocs-swagger-validation-sideefects
branch
from
6a2dc3f
to
d969be0
Compare
|
@eguzki ready for review |
eguzki
approved these changes
Dec 4, 2019
miguelsorianod
deleted the
fix-activedocs-swagger-validation-sideefects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make activedocs apply command not set skip_swagger_validations on activedocs update.
Notice that this breaks compatibility with possible existing scripts so we should document in the new release that the scripts should be updated. It also changes default behavior, although it is a fix to a behavior that it should not exist.