Application plan import: input resource as source of truth

[eguzki]

Application plan import command takes as source of truth the imported resource

[eguzki]

ready for review @miguelsorianod

[miguelsorianod]

Can you provide some context about why do we want the behavior changed? What's the motivation of it? Is there some issue or something where the motivation is explained?

If I understand correctly, we have changed the behavior, where:

• Before: When importing application plan, we only import the pricing rules and limits that exist in the import file that at the same time don't exist in the service where we want to import them. It's like sort of a merge behaviour, but we don't merge the ones existing in both sides.
• Now: When importing an application plan, if there are any existing pricing rules and limits in the service we want to import to, we delete all of them and we import the ones defined in the import file. It's sort of a set behaviour, where we set what is defined in the import file side

Am I correct?

Thank you.

[miguelsorianod]

Code looks good to me. Left a comment related to the purpose of this changes.

Additionally, I think it would be a good idea to document this behaviour change at least in the changelog, as I understand it can potentially affect users of the tool with existing scripts or automated pipelines that they might have

[eguzki]

Can you provide some context about why do we want the behavior changed? What's the motivation of it? Is there some issue or something where the motivation is explained?

https://issues.redhat.com/browse/THREESCALE-3874
https://issues.redhat.com/browse/THREESCALE-3211

• Before: When importing application plan, we only import the pricing rules and limits that exist in the import file that at the same time don't exist in the service where we want to import them. It's like sort of a merge behaviour, but we don't merge the ones existing in both sides.
• Now: When importing an application plan, if there are any existing pricing rules and limits in the service we want to import to, we delete all of them and we import the ones defined in the import file. It's sort of a set behaviour, where we set what is defined in the import file side
  Am I correct?

Yes your are correct. The main implication with the change in the "merge strategy" is that with the SET semantics, existing limits and pricing rules not related with the imported file content will be deleted as well.

[miguelsorianod]

👍 With the issues that contain context information is much more clear thanks