-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup keep alive connections #342
Conversation
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 98.54% 89.46% -9.09%
==========================================
Files 337 224 -113
Lines 16714 8131 -8583
==========================================
- Hits 16470 7274 -9196
- Misses 244 857 +613
Continue to review full report at Codecov.
|
@@ -42,17 +42,6 @@ OPTIONS | |||
ActiveDocs | |||
--skip-swagger-validations Specify it to skip validation of the | |||
Swagger specification | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where this docs pending to be regenerated before this PR? I see several removals for different docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those removals do not belong to this PR. They are common options, not for the specific command being documented, but for the base commands. I think the options for the base commands is not necessary to document here. I added a new option to the top level command 3scale
and I had to update all the docs for all the subcomands. So I decided to remove.
To be clear, the base command options are still printed when you invoke help, it is just removed from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the comment I left and if that is expected it can be merged
Currently, each 3scale admin API call required to setup a new TCP/HTTP connection. For 3scale commands running multiple 3scale API calls, the toolbox spends a lot of time on TCP/HTTP connection setup. Specially true for TLS connections.
With this change, by default, the connection opened by the 3scale toolbox command (if the command requires opening a connection) will be setup to keep alive. Thus, all API calls required for the command will reuse the connection.
If, for whatever reason, the
Connection: close
behavior is desired, the PR includes a new top level option parameter: