Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated update service command #349

Merged
merged 1 commit into from
Jan 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ COMMANDS
proxy-config proxy-config super command
remote remotes super command
service services super command
update [DEPRECATED] update super command

OPTIONS
-c --config-file=<value> 3scale toolbox configuration file (default:
Expand Down Expand Up @@ -178,7 +177,6 @@ Then register the core command in `lib/3scale_toolbox/commands.rb`
+++ b/lib/3scale_toolbox/commands.rb
@@ -4,6 +4,7 @@ require '3scale_toolbox/commands/copy_command'
require '3scale_toolbox/commands/import_command'
require '3scale_toolbox/commands/update_command'
require '3scale_toolbox/commands/remote_command'
+require '3scale_toolbox/commands/service_list_command'

Expand All @@ -187,7 +185,6 @@ Then register the core command in `lib/3scale_toolbox/commands.rb`
@@ -12,7 +13,8 @@ module ThreeScaleToolbox
ThreeScaleToolbox::Commands::CopyCommand,
ThreeScaleToolbox::Commands::ImportCommand,
ThreeScaleToolbox::Commands::UpdateCommand,
- ThreeScaleToolbox::Commands::RemoteCommand::RemoteCommand
+ ThreeScaleToolbox::Commands::RemoteCommand::RemoteCommand,
+ ThreeScaleToolbox::Commands::ServiceListCommand
Expand Down
2 changes: 0 additions & 2 deletions lib/3scale_toolbox/commands.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
require '3scale_toolbox/commands/proxy_command'
require '3scale_toolbox/commands/help_command'
require '3scale_toolbox/commands/import_command'
require '3scale_toolbox/commands/update_command'
require '3scale_toolbox/commands/remote_command'
require '3scale_toolbox/commands/plans_command'
require '3scale_toolbox/commands/metrics_command'
Expand All @@ -24,7 +23,6 @@ module Commands
ThreeScaleToolbox::Commands::HelpCommand,
ThreeScaleToolbox::Commands::CopyCommand,
ThreeScaleToolbox::Commands::ImportCommand,
ThreeScaleToolbox::Commands::UpdateCommand,
ThreeScaleToolbox::Commands::RemoteCommand::RemoteCommand,
ThreeScaleToolbox::Commands::PlansCommand,
ThreeScaleToolbox::Commands::MetricsCommand,
Expand Down
22 changes: 0 additions & 22 deletions lib/3scale_toolbox/commands/update_command.rb

This file was deleted.

80 changes: 0 additions & 80 deletions lib/3scale_toolbox/commands/update_command/service_command.rb

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

21 changes: 3 additions & 18 deletions spec/shared_contexts.rb
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ def get_plugin_content(command_class_name, command_name)
let(:http_client) do
ThreeScale::API::HttpClient.new(endpoint: endpoint,
provider_key: provider_key,
verify_ssl: verify_ssl)
verify_ssl: verify_ssl,
keep_alive: true,
)
end

let(:api3scale_client) { ThreeScale::API::Client.new(http_client) }
Expand All @@ -89,23 +91,6 @@ def get_plugin_content(command_class_name, command_name)
backend_usage_list.map(&:backend).each(&:delete)
source_service.delete

#backend_usage_list = begin
# source_service.backend_usage_list
# rescue ThreeScale::API::HttpClient::NotFoundError
# []
# end
#backend_usage_list.map(&:backend).each do |backend|
# Helpers.wait do
# begin
# backend.delete
# rescue ThreeScale::API::HttpClient::NotFoundError
# true
# rescue ThreeScale::API::HttpClient::ForbiddenError
# false
# end
# end
#end

# delete target activedocs
target_service.activedocs.each do |activedoc|
target_service.remote.delete_activedocs(activedoc.id)
Expand Down

This file was deleted.

84 changes: 0 additions & 84 deletions spec/unit/commands/update_command/service_command_spec.rb

This file was deleted.