Update CustomResourceDefinition API version to v1 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsorianod
force-pushed
the
update-crdtype-to-v1-version
branch
from
999fe87
to
327eb84
Compare
… configsource JSON strategic merge does not allow merging content to an array element when the array does not have a mergeKey defined. We change to JSON Patch for the APIcast configuration source patch that adds anyOf OpenAPI validation
miguelsorianod
force-pushed
the
update-crdtype-to-v1-version
branch
from
327eb84
to
819013c
Compare
miguelsorianod
changed the title
eguzki
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the API Version of the
CustomResourceDefinitionAPI type fromv1beta1tov1for our CRDs.The motivation of this is that K8s is going to stop serving
v1beta1in K8s 1.22:related issue: kubernetes/kubernetes#82022
It is important to not confuse the APIVersion of the
CustomResourceDefinitionAPI type with the APIVersion of our CRD Types. They are different concepts. In this PR we are dealing with the former.The following changes have been performed:
v1version of CustomResourceDefinition.v1anyOfOpenAPI validation of the APIcast configuration source to use JSON Patch instead of JSON Strategic Merge patch. The reason for this is that now that the OpenAPI validation appears in an array of versions there's no way to perform a merge with JSON Strategic Merge patch on the array element contents as it lacks a merge key definitionv1CustomResourceDefinition format. The OpenAPI validation is now specified in the versions array instead of directly in the spec.