[cli] fix logging to syslog #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| local new = _M.new | ||
|
|
||
| local log_levels = { | ||
| debug = ngx.DEBUG, |
There was a problem hiding this comment.
value assigned to field 'debug' is overwritten on line 21 before use
davidor
reviewed
Aug 28, 2018
| use lib 't'; | ||
| use Test::APIcast::Blackbox 'no_plan'; | ||
|
|
||
| repeat_each(3); |
There was a problem hiding this comment.
2 probably would do, but I feel better with 3
davidor
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #712
Fixes issue introduced by #857
Log path starting with
syslog:ormemory:is not relative path, buthas to be passed to nginx unchanged.
For how to configure syslog see nginx documentation: http://nginx.org/en/docs/syslog.html