experimental path based routing #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2016
1. match services by host 2. when host matches, try to match mapping rules 3. if no services match both host and mapping rules 4. fallback to matching by host
|
👍 |
|
Forget to comment here earlier. Tested and looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #22
@tnscorcoran after merging this you'll be able to start the gateway with
APICAST_PATH_ROUTING_ENABLEDenvironment variable set to whatever to enable this feature.It will allow you to have two services with the same host, but still route to the one that matches the rules.
So if you have services A and B both with host 'api.example.com' where
A matches GET /a
and B matches GET /b
you'll be able to make requests:
just fine and they'll be routed to the appropriate service.
/cc @vramosp correct me if I'm not explaining it clearly