Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hides radio buttons when Service Discovery not accesible #1046

Merged
merged 2 commits into from Aug 2, 2019
Merged

Hides radio buttons when Service Discovery not accesible #1046

merged 2 commits into from Aug 2, 2019

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Aug 2, 2019 •
edited

  • When service_discovery_accesible? is true:
    Screen Shot 2019-08-02 at 11 56 21

  • When service_discovery_accesible? is false:
    Screen Shot 2019-08-02 at 11 55 21

  • When service_discovery_enabled? is true:
    Screen Shot 2019-08-02 at 12 03 52

@josemigallas josemigallas requested a review from a team August 2, 2019 10:02
@josemigallas josemigallas self-assigned this Aug 2, 2019
thomasmaas
thomasmaas requested changes Aug 2, 2019
View reviewed changes
Copy link
Member

@thomasmaas thomasmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessible

@josemigallas josemigallas force-pushed the hotfix/hide_radio_buttons_new_api branch from 63456f8 to 631ecf7 Compare August 2, 2019 10:31
@josemigallas josemigallas changed the title 🐛 Hides radio buttons when Service Discovery not accesible Hides radio buttons when Service Discovery not accesible Aug 2, 2019
@josemigallas josemigallas added Priority: Blocker This PR is a blocker. Everyone should review and help to close it ASAP. javascript Pull requests that update Javascript code labels Aug 2, 2019
@josemigallas josemigallas changed the title Hides radio buttons when Service Discovery not accesible 🐛 Hides radio buttons when Service Discovery not accesible Aug 2, 2019
@guicassolato guicassolato merged commit 4f70d13 into master Aug 2, 2019
@guicassolato guicassolato deleted the hotfix/hide_radio_buttons_new_api branch August 2, 2019 10:55
guicassolato added a commit that referenced this pull request Aug 2, 2019
@guicassolato
Merge pull request #1046 from 3scale/hotfix/hide_radio_buttons_new_api
d41e5bd 
🐛 Hides radio buttons when Service Discovery not accesible
@josemigallas josemigallas changed the title 🐛 Hides radio buttons when Service Discovery not accesible Hides radio buttons when Service Discovery not accesible Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmaas thomasmaas thomasmaas approved these changes

@guicassolato guicassolato guicassolato approved these changes

@didierofrivia didierofrivia didierofrivia approved these changes

@damianpm damianpm damianpm approved these changes

Assignees

@josemigallas josemigallas

Labels
javascript Pull requests that update Javascript code Priority: Blocker This PR is a blocker. Everyone should review and help to close it ASAP.
Projects
None yet
Milestone
No milestone
5 participants
@josemigallas @thomasmaas @guicassolato @didierofrivia @damianpm