Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Plan "Methods & Metrics" collapsible table #1113

Merged

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Aug 22, 2019

What this PR does / why we need it:

Adds a caret to the title and hides/shows the table.

metrics

Which issue(s) this PR fixes

THREESCALE-3093: APIAP: Application plan > edit > Methods & Metrics - Collapsible table

Tested in:

  • Firefox
  • Chrome
  • Safari (although it jumps to the top when resizing the table 馃悰)
  • IE11

Verification steps

  • Go to apiconfig/application_plans/22/edit and click on the names of each Backend API under Metrics, Methods, Limits & Pricing Rules
  • Metrics from each particular API should collapse/expande
  • The caret should rotate
  • When no JS, there shouldn't any caret
  • When no metrics, there shouldn't any caret either

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this issue was not well explained in the Jira. As stated in the tracking document for the implementation of APIAP in porta, the tables (plural) to make expandable/collapsible are the ones of the metrics and methods of each backend API, not the whole section of methods and metrics of the page.

@josemigallas josemigallas force-pushed the feature/THREESCALE-3093_metrics_collapsible_table branch 2 times, most recently from fdf9da7 to 4226d19 Compare August 26, 2019 10:06
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #1113 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1113     +/-   ##
=========================================
- Coverage   92.33%   92.23%   -0.1%     
=========================================
  Files        2386     2370     -16     
  Lines       78804    76832   -1972     
=========================================
- Hits        72764    70868   -1896     
+ Misses       6040     5964     -76
Impacted Files Coverage 螖
app/lib/csv/messages_exporter.rb 16.66% <0%> (-75%) 猬囷笍
app/lib/logic/nginx_proxy.rb 27.27% <0%> (-72.73%) 猬囷笍
lib/last_traffic.rb 33.33% <0%> (-66.67%) 猬囷笍
app/lib/events/importers/alert_importer.rb 33.33% <0%> (-62.75%) 猬囷笍
lib/range_hacks.rb 37.5% <0%> (-62.5%) 猬囷笍
app/models/numeric_hash.rb 41.17% <0%> (-58.83%) 猬囷笍
app/workers/janitor_worker.rb 42.85% <0%> (-57.15%) 猬囷笍
.../initializers/backport_pg_10_support_to_rails_4.rb 30% <0%> (-50%) 猬囷笍
app/workers/purge_stale_objects_worker.rb 50% <0%> (-50%) 猬囷笍
config/initializers/postgres.rb 50% <0%> (-50%) 猬囷笍
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b2be76c...f33475d. Read the comment docs.

guicassolato
guicassolato previously approved these changes Aug 26, 2019
@josemigallas josemigallas force-pushed the feature/THREESCALE-3093_metrics_collapsible_table branch from df3760a to ab95da2 Compare August 27, 2019 15:55
@guicassolato guicassolato merged commit c55b60d into master Aug 27, 2019
@guicassolato guicassolato deleted the feature/THREESCALE-3093_metrics_collapsible_table branch August 27, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants