Make independent mapping rules always enabled when APIAP is on #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duduribeiro
force-pushed
the
make_independent_mapping_rules_always_enabled_for_apiap
branch
from
c588425
to
09fa0ef
Compare
makikata
reviewed
Aug 30, 2019
makikata
reviewed
Aug 30, 2019
makikata
reviewed
Aug 30, 2019
makikata
reviewed
Aug 30, 2019
app/views/api/integrations/apicast/shared/_mapping_rules.html.slim
Outdated
Show resolved
Hide resolved
makikata
reviewed
Aug 30, 2019
app/views/shared/provider/navigation/service/_integration.html.slim
Outdated
Show resolved
Hide resolved
makikata
suggested changes
Aug 30, 2019
duduribeiro
force-pushed
the
make_independent_mapping_rules_always_enabled_for_apiap
branch
2 times, most recently
from
7405cc6
to
c7201fd
Compare
Martouta
changed the title
Martouta
added
on hold
duduribeiro
changed the title
duduribeiro
force-pushed
the
make_independent_mapping_rules_always_enabled_for_apiap
branch
from
c7201fd
to
9b18548
Compare
Martouta
previously approved these changes
Sep 12, 2019
hallelujah
reviewed
Sep 12, 2019
| @@ -44,7 +44,7 @@ def destroy | |||
| private | |||
|
|
|||
| def authorize! | |||
| provider_can_use!(:independent_mapping_rules) | |||
| provider_can_use!(:api_as_product) | |||
There was a problem hiding this comment.
It should be provider_can_use!(:api_as_product) || provider_can_use!(:independent_mapping_rules) @thomasmaas ?
There was a problem hiding this comment.
I would say provider_can_use!(:api_as_product) is enough, unless we have customers on saas who are using this? As in our next on prem release all providers can and will use api_as_product
THREESCALE-3341 We need to make independent_mapping_rules always enabled for services acting as product.
duduribeiro
force-pushed
the
make_independent_mapping_rules_always_enabled_for_apiap
branch
from
9b18548
to
2cb24b8
Compare
hallelujah
approved these changes
Sep 13, 2019
duduribeiro
deleted the
make_independent_mapping_rules_always_enabled_for_apiap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We need to make independent_mapping_rules always enabled for
services acting as product.
Which issue(s) this PR fixes
THREESCALE-3341
Depends on #1156