Fix Backend API mapping rules injected into the proxy config #1193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Backend api mapping rules injected in the proxy config have two problems:
system_name
of the metric but only the part without the.#{backend_api.id}
suffixFirst problem is due to draper's
delegate_all
method used inporta/app/decorators/application_decorator.rb
Line 4 in ccc776c
ProxyRuleDecorator#pattern
to execute only once and then always be delegated to the object.See drapergem/draper#818
The second problem is because of
porta/app/lib/backend_api_logic/metric_extension.rb
Lines 13 to 15 in ccc776c
What this PR does
path
of Backend API mapping rules injected into the proxy configsystem_name
of Backend API mapping rules injected into the proxy configVerification steps
.#{backend_api.id}
suffix appended to the end ofmetric_system_name