Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Backend API config to product #1226

Merged
merged 2 commits into from Sep 23, 2019
Merged

Add Backend API config to product #1226

merged 2 commits into from Sep 23, 2019

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Sep 23, 2019 •
edited

@guicassolato guicassolato self-assigned this Sep 23, 2019
Martouta
Martouta reviewed Sep 23, 2019
View reviewed changes
config/abilities/provider_admin.rb
@@ -78,6 +78,7 @@

if account.provider_can_use?(:api_as_product)
can :manage, BackendApi
can :manage, BackendApiConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so I definitely have to reuse this then 👍 taking notes... 😄

@Martouta Martouta changed the title Add Backend API config to product [WIP] Add Backend API config to product Sep 23, 2019
@guicassolato
BackendApiConfig validation
3ee6587 
* presence of service and backend_api
* uniqueness of path scoped by service

Fix factory trait (simple_)service :with_default_backend_api
@guicassolato
Add Backend API config to product
49353c4 
Closes https://issues.jboss.org/browse/THREESCALE-3321
@guicassolato guicassolato changed the title [WIP] Add Backend API config to product Add Backend API config to product Sep 23, 2019
Martouta
Martouta approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@Martouta Martouta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it 😍 👏 🥇

thomasmaas
thomasmaas approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@thomasmaas thomasmaas left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

future improvement could add a link to 'create new backend' from within form, linking to new backend form but not needed now.

@Martouta Martouta merged commit d76fdf8 into master Sep 23, 2019
@Martouta Martouta deleted the apiap-new-backend-api-config branch September 23, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmaas thomasmaas thomasmaas approved these changes

@hallelujah hallelujah hallelujah approved these changes

@macejmic macejmic macejmic approved these changes

@Martouta Martouta Martouta approved these changes

Assignees

@guicassolato guicassolato

Labels
APIAP
Projects
None yet
Milestone
No milestone
5 participants
@guicassolato @thomasmaas @hallelujah @macejmic @Martouta