Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policies update button #1256

Merged
merged 6 commits into from Sep 28, 2019
Merged

Policies update button #1256

merged 6 commits into from Sep 28, 2019

Conversation

josemigallas
Copy link
Contributor

What this PR does / why we need it:

  • Hides Form's submit button when a policy is being edited (so that there is only 1 button at the same time)
  • Renders Form's submit button disabled by default and enables it after any change (so that it makes more obvious that the changes are yet to be saved)

Which issue(s) this PR fixes

THREESCALE-3546: Policies: remove double update button

policies

@josemigallas josemigallas requested a review from a team September 27, 2019 09:04
@josemigallas josemigallas self-assigned this Sep 27, 2019
Martouta
Martouta approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@Martouta Martouta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 💪

@josemigallas josemigallas force-pushed the THREESCALE-3546_policies_update_button branch from 6c867b6 to 3196750 Compare September 27, 2019 15:48
@josemigallas josemigallas force-pushed the THREESCALE-3546_policies_update_button branch from 3196750 to 276ef40 Compare September 27, 2019 15:59
@josemigallas josemigallas force-pushed the THREESCALE-3546_policies_update_button branch from 276ef40 to a631380 Compare September 27, 2019 16:01
@hallelujah hallelujah merged this pull request into apiap/extract-policies Sep 28, 2019
@josemigallas josemigallas deleted the THREESCALE-3546_policies_update_button branch September 30, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guicassolato guicassolato guicassolato left review comments

@damianpm damianpm damianpm left review comments

@hallelujah hallelujah hallelujah approved these changes

@Martouta Martouta Martouta approved these changes

@didierofrivia didierofrivia Awaiting requested review from didierofrivia

@thomasmaas thomasmaas Awaiting requested review from thomasmaas

Assignees

@josemigallas josemigallas

Labels
APIAP
Projects
None yet
Milestone
No milestone
6 participants
@josemigallas @hallelujah @guicassolato @didierofrivia @Martouta @damianpm