Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] [wip] Hotfix: Do not disable promote to staging #1352

Closed
wants to merge 1 commit into from

Conversation

hallelujah
Copy link
Contributor

@hallelujah hallelujah commented Oct 21, 2019

We are unsure yet if the proxy config affecting change is fully complete

Fixes: https://issues.jboss.org/browse/THREESCALE-3760

Proposal is to quick fix it (because of ER2)

Then probably use in a later PR something like:

https://github.com/3scale/porta/blob/master/app/services/apicast_v2_deployment_service.rb#L13-L15

We are unsure yet if the proxy config affecting change is fully complete

Fixes: https://issues.jboss.org/browse/THREESCALE-3760
@hallelujah hallelujah changed the title Hotfix: Do not disable promote to production Hotfix: Do not disable promote to staging Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@12c1b2d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1352   +/-   ##
=========================================
  Coverage          ?   91.75%           
=========================================
  Files             ?     2328           
  Lines             ?    74975           
  Branches          ?        0           
=========================================
  Hits              ?    68794           
  Misses            ?     6181           
  Partials          ?        0
Impacted Files Coverage Δ
app/helpers/api/integrations_helper.rb 86.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c1b2d...0ca79e4. Read the comment docs.

@guicassolato guicassolato changed the title Hotfix: Do not disable promote to staging [do not merge] Hotfix: Do not disable promote to staging Oct 21, 2019
@guicassolato guicassolato changed the title [do not merge] Hotfix: Do not disable promote to staging [do not merge] [wip] Hotfix: Do not disable promote to staging Oct 21, 2019
@guicassolato
Copy link
Contributor

Let's wait a little bit before merging this. In the end we may need it for 2.7 GA, but for now #1354 already fixed the specific issue reported in https://issues.jboss.org/browse/THREESCALE-3760.

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentioned in the comment was closed. Although we had a new report yesterday (yet to be confirmed, BTW), I really don't think this is the way to go. If the issue is confirmed, we need to find the root cause of it.

@hallelujah
Copy link
Contributor Author

Closing, it seems we do not need it. We are going to improve the proxy affecting changes.

@hallelujah hallelujah closed this Feb 17, 2020
@hallelujah hallelujah deleted the enable-promote-to-production branch February 17, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants