-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] [wip] Hotfix: Do not disable promote to staging #1352
Conversation
We are unsure yet if the proxy config affecting change is fully complete Fixes: https://issues.jboss.org/browse/THREESCALE-3760
4dfdeec
to
0ca79e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
=========================================
Coverage ? 91.75%
=========================================
Files ? 2328
Lines ? 74975
Branches ? 0
=========================================
Hits ? 68794
Misses ? 6181
Partials ? 0
Continue to review full report at Codecov.
|
Let's wait a little bit before merging this. In the end we may need it for 2.7 GA, but for now #1354 already fixed the specific issue reported in https://issues.jboss.org/browse/THREESCALE-3760. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue mentioned in the comment was closed. Although we had a new report yesterday (yet to be confirmed, BTW), I really don't think this is the way to go. If the issue is confirmed, we need to find the root cause of it.
Closing, it seems we do not need it. We are going to improve the proxy affecting changes. |
We are unsure yet if the proxy config affecting change is fully complete
Fixes: https://issues.jboss.org/browse/THREESCALE-3760
Proposal is to quick fix it (because of ER2)
Then probably use in a later PR something like:
https://github.com/3scale/porta/blob/master/app/services/apicast_v2_deployment_service.rb#L13-L15