Fix Pricing Rules and Limits endpoints to accept metrics from BackendApi #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THREESCALE-3746 Currently when the user tries to create/update/delete limits or pricing rules for a Backend API metric in a plan it fails with 404. This commit fixes it by making the controller consider the backend api metrics using the `all_metrics` method from the plan.
guicassolato
approved these changes
Oct 22, 2019
guicassolato
deleted the
pricing_rules_when_backend_does_not_have_product
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THREESCALE-3746
Currently when the user tries to create/update/delete limits or pricing
rules for a Backend API metric in a plan it fails with 404.
This commit fixes it by making the controller consider the backend api
metrics using the
all_metricsmethod from the plan.