Extend API Switcher to Context Selector #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmaas
approved these changes
Oct 15, 2018
| "react": "^16.0.0", | ||
| "react-dom": "^16.0.0", | ||
| "react": "^16.5.2", | ||
| "react-dom": "^16.5.2", |
There was a problem hiding this comment.
Missing yarn.lock, was this updated with npm? Is it needed for React.Fragments, right?
There was a problem hiding this comment.
No and yes, fixing now
| @@ -144,7 +144,7 @@ | |||
| "css-loader": "^0.28.9", | |||
| "empty": "^0.10.1", | |||
| "enzyme": "^3.3.0", | |||
| "enzyme-adapter-react-16": "^1.1.1", | |||
| "enzyme-adapter-react-16": "^1.6.0", | |||
There was a problem hiding this comment.
same here, update and lock the dependency
| case 'monitoring': | ||
| return `API: ${currentApi.service.name}` | ||
|
|
||
| default: |
There was a problem hiding this comment.
it could be useful to have default "Dashboard", and write a simple test with some of the options. Also, next iteration applying flow types and define currentApi, since we are relying on it calling 2 methods.
There was a problem hiding this comment.
How about Choose an API as default case?
didierofrivia
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactors and extends current API switcher into a ContextSelector component. It features a quick link to Audience before the usual API browser and also displays the name of the current context.
Which issue(s) this PR fixes
https://issues.jboss.org/browse/THREESCALE-1395