Prevent trailing slash in patterns of proxy rules of backend api configs with a path #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmaas
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
@guicassolato as this behaviour doesn't seem to be transparent we might want to ping @3scale/documentation to add a note about this in docs?
| return pattern_value unless backend_api_path | ||
| parts = ['/', backend_api_path] | ||
| parts << pattern_value unless pattern_value == '/' | ||
| File.join(*parts) |
There was a problem hiding this comment.
Question: is it not better to manipulate the path with the rails UrlHelper ?
There was a problem hiding this comment.
I agree with @didierofrivia , this way it seems that it is somehow related to a File, but it isn't 🤔
another alternative would be parts.join('/')
There was a problem hiding this comment.
Spoken with Gui. I will push this fix after lunch in another PR 👍
hallelujah
approved these changes
Nov 5, 2019
eloycoto
approved these changes
Nov 5, 2019
|
@guicassolato @thomasmaas You can create a JIRA and we'll add the note. |
Martouta
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make proxy rules whose pattern is the "catch-all" pattern
/not to end with the slash if the pattern has been prepended by a backend api path.Example 1
Backend path:
/mybackendProxy rule pattern:
/Actual proxy rule pattern in the config:
/mybackend(it used to be/mybackend/before this PR)Example 2
Backend path:
/mybackendProxy rule pattern:
/helloActual proxy rule pattern in the config:
/mybackend/hello(same as before)Example 3
Backend path:
/Proxy rule pattern:
/Actual proxy rule pattern in the config:
/(same as before)Example 4
Backend path:
/Proxy rule pattern:
/helloActual proxy rule pattern in the config:
/hello(same as before)Closes THREESCALE-3833