Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible policy when re-ordering Policy Chain #1460

Merged
merged 1 commit into from Nov 27, 2019

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Nov 27, 2019

What this PR does / why we need it:

When dragging a policy from the policy chain, it disappears.

This PR adds a css class to the item being dragged (via helperClass prop) which sets a high enough z-index and a background.

Before:
sortable-before

After:
sortable-after

Which issue(s) this PR fixes

Closes THREESCALE-4017

Verification steps

  1. Go to a Product > Integration > Policies (apiap) or Service > Integration settings (non apiap)
  2. Sort policy chain: the policy being moved should be visible

@josemigallas josemigallas added the javascript Pull requests that update Javascript code label Nov 27, 2019
@josemigallas josemigallas requested a review from a team November 27, 2019 10:18
@josemigallas josemigallas self-assigned this Nov 27, 2019
thomasmaas
thomasmaas previously approved these changes Nov 27, 2019
@josemigallas josemigallas force-pushed the policies/fix_invisible_when_dragging branch from 8ae2b8c to f1d6a32 Compare November 27, 2019 10:37
@josemigallas josemigallas merged commit 6f74302 into master Nov 27, 2019
@josemigallas josemigallas deleted the policies/fix_invisible_when_dragging branch November 27, 2019 10:55
guicassolato pushed a commit that referenced this pull request Dec 4, 2019
…ging

Fix invisible policy when re-ordering Policy Chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
3 participants