New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge all routing policies into one #1465
Conversation
c3c194d
to
0d82898
Compare
Codecov Report
@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
- Coverage 90.47% 63.18% -27.3%
==========================================
Files 2252 1509 -743
Lines 70471 40928 -29543
==========================================
- Hits 63760 25861 -37899
- Misses 6711 15067 +8356
Continue to review full report at Codecov.
|
0d82898
to
bc9af47
Compare
bc9af47
to
3381ed0
Compare
|
||
routing_policy = Builder.new(service).to_h | ||
|
||
return other_policies if routing_policy['configuration']['rules'].concat(other_routing_rules).empty? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rules
can be nil
in some policies. But agree that for routing
it must be an Array
[{"configuration":{},"name":"apicast","version":"builtin","enabled":true},{"configuration":{"rules":[]},"name":"routing","version":"builtin","enabled":true}]
Merge all routing policies into one
This is one of the options we have to fix THREESCALE-4016 It corresponds to the first solution proposed in the dev notes.