New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename proxy deployment service to v1 #1469
Conversation
238fbcb
to
3716ad5
Compare
3716ad5
to
07702ab
Compare
07702ab
to
ed7e9b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
+ Coverage 89.77% 92.43% +2.66%
==========================================
Files 2185 2355 +170
Lines 67076 75774 +8698
==========================================
+ Hits 60215 70044 +9829
+ Misses 6861 5730 -1131
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a first step into defining a new ProviderProxyDeploymentService
. When we finally drop support for apicast v1, this service will be removed as stated in the description of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/3scale/porta/pull/1469/files#r354235871 is important 😄
Everything else is good 👍
30117ba
to
5a9b2b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What this PR does / why we need it:
This is a simple refactorization.
ProviderProxyDeploymentService
handles only APIcast v1 deployments and this is going to be removed soon. In order to make a new service for v2, this one is to be renamed toProxyDeploymentServiceV1
. This way it will be easier to remove and also we won't mix responsibilities.Which issue(s) this PR fixes
Works towards THREESCALE-3751: Tech-Debt: Create a Proxy Deployment Service, but doesn't fix it.
Verification steps
Everything deployment-wise should work the same.