Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename proxy deployment service to v1 #1469

Merged
merged 2 commits into from Dec 5, 2019

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Dec 4, 2019

What this PR does / why we need it:

This is a simple refactorization.

ProviderProxyDeploymentService handles only APIcast v1 deployments and this is going to be removed soon. In order to make a new service for v2, this one is to be renamed to ProxyDeploymentServiceV1. This way it will be easier to remove and also we won't mix responsibilities.

Which issue(s) this PR fixes

Works towards THREESCALE-3751: Tech-Debt: Create a Proxy Deployment Service, but doesn't fix it.

Verification steps

Everything deployment-wise should work the same.

@josemigallas josemigallas added the ruby Pull requests that update Ruby code label Dec 4, 2019
@josemigallas josemigallas requested a review from a team December 4, 2019 12:11
@josemigallas josemigallas self-assigned this Dec 4, 2019
@josemigallas josemigallas force-pushed the rename_proxy_deployment_service_v1 branch from 238fbcb to 3716ad5 Compare December 4, 2019 12:32
@josemigallas josemigallas marked this pull request as ready for review December 4, 2019 13:06
app/models/proxy.rb Outdated Show resolved Hide resolved
@josemigallas josemigallas force-pushed the rename_proxy_deployment_service_v1 branch from 3716ad5 to 07702ab Compare December 4, 2019 13:26
@josemigallas josemigallas force-pushed the rename_proxy_deployment_service_v1 branch from 07702ab to ed7e9b0 Compare December 4, 2019 15:11
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #1469 into master will increase coverage by 2.66%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
+ Coverage   89.77%   92.43%   +2.66%     
==========================================
  Files        2185     2355     +170     
  Lines       67076    75774    +8698     
==========================================
+ Hits        60215    70044    +9829     
+ Misses       6861     5730    -1131
Impacted Files Coverage Δ
...admin/onboarding/wizard/request_controller_test.rb 100% <ø> (ø)
app/workers/proxy_deployment_worker.rb 17.39% <0%> (ø) ⬆️
test/unit/proxy_test.rb 100% <100%> (ø) ⬆️
...vices/provider_proxy_deployment_v1_service_test.rb 100% <100%> (ø)
...p/services/provider_proxy_deployment_v1_service.rb 90.9% <100%> (ø)
app/models/proxy.rb 97.77% <66.66%> (ø) ⬆️
app/mailers/data_export_mailer.rb 40% <0%> (-60%) ⬇️
app/workers/last_traffic_worker.rb 46.15% <0%> (-53.85%) ⬇️
app/workers/purge_stale_objects_worker.rb 50% <0%> (-50%) ⬇️
app/workers/data_exports_worker.rb 50% <0%> (-50%) ⬇️
... and 1044 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c3334...ed7e9b0. Read the comment docs.

@josemigallas josemigallas requested review from guicassolato and a team December 4, 2019 15:12
guicassolato
guicassolato previously approved these changes Dec 5, 2019
Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first step into defining a new ProviderProxyDeploymentService. When we finally drop support for apicast v1, this service will be removed as stated in the description of the PR.

Copy link
Contributor

@Martouta Martouta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/3scale/porta/pull/1469/files#r354235871 is important 😄

Everything else is good 👍

Copy link
Contributor

@Martouta Martouta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josemigallas josemigallas merged commit 99fc8cc into master Dec 5, 2019
@josemigallas josemigallas deleted the rename_proxy_deployment_service_v1 branch December 5, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
3 participants