New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pf4 dark mode #1525
Pf4 dark mode #1525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #1525 +/- ##
=========================================
- Coverage 93.01% 93% -0.01%
=========================================
Files 2516 2516
Lines 83600 83570 -30
=========================================
- Hits 77757 77722 -35
- Misses 5843 5848 +5
Continue to review full report at Codecov.
|
@josemigallas I think there are no transitions or animations anymore, if you look at the examples, they don't have it: |
But there is still some sort of animation going on in preview… |
f5aa4c9
to
8c2dc63
Compare
66332ca
to
81641e0
Compare
Merging and creating a new issue to investigate if the "jump" is a real issue or just something new in PF |
Creating new issue to further investigate
What this PR does / why we need it:
PatternFly is switching by default to dark theme.
See:
https://www.patternfly.org/v4/documentation/react/components/page#examples
And:
https://www.patternfly.org/v4/documentation/react/components/nav
Verification steps
npm run update-dependencies
Special notes for your reviewer:
Before:
After:
Deployed to preview env